Re: [Xen-devel] [PATCH V7] xen/vm_event: Clean up control-register-write vm_events and add XCR0 event

["Lengyel, Tamas" <tlengyel@xxxxxxxxxxx>]

diff --git a/xen/arch/x86/hvm/event.c b/xen/arch/x86/hvm/event.c
index 9d5f9f3..a13195d 100644
--- a/xen/arch/x86/hvm/event.c
+++ b/xen/arch/x86/hvm/event.c
@@ -21,6 +21,7 @@

Â#include <xen/vm_event.h>
Â#include <xen/paging.h>
+#include <asm/monitor.h>
Â#include <public/vm_event.h>

Âstatic void hvm_event_fill_regs(vm_event_request_t *req)
@@ -88,55 +89,28 @@ static int hvm_event_traps(uint8_t sync, vm_event_request_t *req)
  Âreturn 1;
Â}

-static inline
-void hvm_event_cr(uint32_t reason, unsigned long value,
-Â Â Â Â Â Â Â Â Â Â Â Â Âunsigned long old, bool_t onchangeonly, bool_t sync)
+void (hvm_event_cr)(unsigned int index, unsigned long value, unsigned long old)

Any reason to have parenthesis around hvm_event_cr? Also, if you could make the patch available somewhere via git, that would be great, I would like to test it!

Thanks!

--

Tamas K Lengyel

Senior Security Researcher

7921 Jones Branch Drive

McLean VA 22102

Email Âtlengyel@novetta.com

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel