Re: [Xen-devel] [PATCH] dmar: device scope mem leak fix

[Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>]

On Thu, May 28, 2015 at 08:57:16AM +0100, Jan Beulich wrote:
> >>> On 27.05.15 at 21:56, <elena.ufimtseva@xxxxxxxxxx> wrote:
> > On Tue, May 26, 2015 at 10:46:30AM +0100, Jan Beulich wrote:
> >> >>> On 23.05.15 at 03:27, <elena.ufimtseva@xxxxxxxxxx> wrote:
> >> > @@ -658,6 +661,7 @@ acpi_parse_one_rmrr(struct acpi_dmar_header *header)
> >> >                  "  Ignore the RMRR (%"PRIx64", %"PRIx64") due to "
> >> >                  "devices under its scope are not PCI discoverable!\n",
> >> >                  rmrru->base_address, rmrru->end_address);
> >> > +            xfree(rmrru->scope.devices);
> >> >              xfree(rmrru);
> > Do you think the ret should be set in this case also?
> 
> Iirc in an earlier version of the other series you had added a failure
> error code setting here, and I had to specifically ask you to remove
> it. If you still think one is needed here, this would need to be a
> separate patch with a proper explanation.
> 
> Jan

Hi Jan

I do remember this. Looked again and I think it makes sense on ignore
path not to return error.


> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel