Re: [Xen-devel] [RFC][v2][PATCH 05/14] xen/x86/p2m: introduce set_identity_p2m_entry

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

On 2015/5/28 20:27, Jan Beulich wrote:
> > > > On 22.05.15 at 11:35, <tiejun.chen@xxxxxxxxx> wrote:
> > --- a/xen/arch/x86/mm/p2m.c
> > +++ b/xen/arch/x86/mm/p2m.c
> > @@ -898,6 +898,36 @@ int set_mmio_p2m_entry(struct domain *d, unsigned long 
> > gfn, mfn_t mfn,
> >       return set_typed_p2m_entry(d, gfn, mfn, p2m_mmio_direct, access);
> >   }
> >
> > +int set_identity_p2m_entry(struct domain *d, unsigned long gfn,
> > +                           p2m_access_t p2ma)
> > +{
> > +    p2m_type_t p2mt;
> > +    p2m_access_t a;
> > +    mfn_t mfn;
> > +    struct p2m_domain *p2m = p2m_get_hostp2m(d);
> > +    int ret = -EBUSY;
> > +
> > +    gfn_lock(p2m, gfn, 0);
> > +
> > +    mfn = p2m->get_entry(p2m, gfn, &p2mt, &a, 0, NULL);
> > +
> > +    if ( p2mt == p2m_invalid )
> > +        ret = p2m_set_entry(p2m, gfn, _mfn(gfn), PAGE_ORDER_4K,
> > +                            p2m_mmio_direct, p2ma);
> > +    else if ( mfn_x(mfn) == gfn && p2mt == p2m_mmio_direct && a == p2ma )
> > +        ret = 0;
> > +    else
> > +    {
> > +        printk(XENLOG_G_WARNING
> > +               "Cannot identity map d%d:%lx, already mapped to %lx.\n",
> > +               d->domain_id, gfn, mfn_x(mfn));
> > +    }
> With the redundant braces here dropped or the ret = -EBUSY moved
> into this block,
Okay, I will fix this with the latter.

> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Really thanks for your review.

> I also reduced the Cc list quite significantly - I don't understand why
> so many people were Cc-ed on this patch.
I just pick up all guys involving that design we posted previously to 
make sure they also pay attention on this series.
Thanks
Tiejun


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel