Re: [Xen-devel] [PATCHv10 4/4] gnttab: use per-VCPU maptrack free lists

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.05.15 at 18:10, <dvrabel@xxxxxxxxxx> wrote:
> On 28/05/15 16:39, Jan Beulich wrote:
>>>>> On 26.05.15 at 20:00, <david.vrabel@xxxxxxxxxx> wrote:
>>> --- a/xen/common/grant_table.c
>>> +++ b/xen/common/grant_table.c
>>> @@ -57,7 +57,7 @@ integer_param("gnttab_max_frames", max_grant_frames);
>>>   * New options allow to set max_maptrack_frames and
>>>   * map_grant_table_frames independently.
>>>   */
>>> -#define DEFAULT_MAX_MAPTRACK_FRAMES 256
>>> +#define DEFAULT_MAX_MAPTRACK_FRAMES 1024
>> 
>> Apart from everything else this again results in ...
>> 
>>> @@ -1457,6 +1491,17 @@ gnttab_setup_table(
>>>      gt = d->grant_table;
>>>      write_lock(&gt->lock);
>>>  
>>> +    /* Tracking of mapped foreign frames table */
>>> +    gt->maptrack = xzalloc_array(struct grant_mapping *, 
>>> max_maptrack_frames);
>> 
>> ... this becoming an order-1 runtime allocation on other than 32-bit
>> ARM.
> 
> I thought we agreed that this was temporary until vzalloc() was added?

Was it this one? And anyway, the vzalloc() addition went in almost
two weeks ago.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel