Re: [Xen-devel] [PATCH] xen: netback: fix error printf format string.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, May 29, 2015 at 05:22:04PM +0100, Ian Campbell wrote:
> drivers/net/xen-netback/netback.c: In function âxenvif_tx_build_gopsâ:
> drivers/net/xen-netback/netback.c:1253:8: warning: format â%luâ expects 
> argument of type âlong unsigned intâ, but argument 5 has type âintâ 
> [-Wformat=]
>         (txreq.offset&~PAGE_MASK) + txreq.size);
>         ^
> 
> txreq.offset and .size are uint16_t fields.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
>  drivers/net/xen-netback/netback.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/netback.c 
> b/drivers/net/xen-netback/netback.c
> index 4de46aa..a3b1cbb 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1248,7 +1248,7 @@ static void xenvif_tx_build_gops(struct xenvif_queue 
> *queue,
>               /* No crossing a page as the payload mustn't fragment. */
>               if (unlikely((txreq.offset + txreq.size) > PAGE_SIZE)) {
>                       netdev_err(queue->vif->dev,
> -                                "txreq.offset: %x, size: %u, end: %lu\n",
> +                                "txreq.offset: %x, size: %u, end: %u\n",
>                                  txreq.offset, txreq.size,
>                                  (txreq.offset&~PAGE_MASK) + txreq.size);
>                       xenvif_fatal_tx_err(queue->vif);
> -- 
> 1.7.10.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel