[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V4 5/8] tools/libxl: Set 'reg' of cpu node equal to MPIDR affinity for domU

Hi Julien,

On Fri, May 29, 2015 at 05:08:08PM +0100, Julien Grall wrote:
> On 29/05/15 16:55, Ian Campbell wrote:
> > On Fri, 2015-05-29 at 16:44 +0100, Julien Grall wrote:
> > 
> >>> +        name = GCSPRINTF("cpu@%lx", mpidr_aff);
> >>
> >> It's not necessary to change the cpu@.
> > 
> > AIUI it is conventional in DT for this to match the first reg entry.
> Well, it's conventional when the reg field is containing an address.
> It's not the case of the cpu node as "reg" doesn't contain an address.
> There is a mix of both in the different DTS.
> Although, increment an ID make easier to read the dumped DTS for debugging.

I did the change because it would be more friendly for user to read the
cpu node in /proc/device-tree/. Because the number is no longer continuous
when we have a guest more than 16 cpus. In that case, the cpu nodes will be
looked like as the following:

cpu@0, cpu@1, ..., cpu@15, cpu@256, cpu@257, ..., cpu@271, cpu@512, ...

Considering changing to the new form doesn't introduce new risk (and follows
the convention to a certain degree), I prefer the new way.



Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.