Re: [Xen-devel] [PATCH V5 03/10] xen/arm: Use the new functions for vCPUID/vaffinity transformation

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Chen,

On 30/05/2015 12:07, Chen Baozi wrote:
> From: Chen Baozi <baozich@xxxxxxxxx>
>
> There are 3 places to change:
>
> * Initialise vMPIDR value in vcpu_initialise()
> * Find the vCPU from vMPIDR affinity information when accessing GICD
>    registers in vGIC
> * Find the vCPU from vMPIDR affinity information when booting with vPSCI
>    in vGIC
>    - Also make the code for PSCI 0.1 use MPIDR-like value as the cpuid.
>
> Signed-off-by: Chen Baozi <baozich@xxxxxxxxx>
> ---
> Comments from Julien in the previous review:
>
> I read more closely the spec of PSCI 0.1 Section 6.3 (ARM DEN 0022A):
>
> "Ideally platform discovery mechanism such as firmware tables would be
> used by secure firmware to describe the set of valid CPUIDs to the
> hypervisor or Rich OS, if the former is not present. The hypervisor in
> turn can create and supply virtual discovery mechanisms to its guests."
>
> It looks like to me that the CPUID is equal to the "reg" field in the
> CPU node which is an MPIDR-like value. So I think the affinity should be
> called in both case.
Assuming that I was right here:

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel