Re: [Xen-devel] [PATCH v23 10/15] x86/VPMU: Use pre-computed masks when checking validity of MSRs

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.05.15 at 20:42, <boris.ostrovsky@xxxxxxxxxx> wrote:
> No need to compute those masks on every MSR access.
> 
> Also, when checking MSR_P6_EVNTSELx registers make sure that bit 21
> is not set.

I had hoped you would save me and other readers to look up what
this bit means by giving a reason why this change is wanted/needed.
What you say above is at best marginally more useful (it clarifies that
this isn't a stray change) than having the adjustment only in the code.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel