Re: [Xen-devel] [PATCH] tools: link executables with libtinfo explicitly

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jun 01, 2015 at 03:26:58PM +0200, Daniel Kiper wrote:
[...]
> > >  tools/misc/Makefile           |    2 +-
> > >  tools/xenstat/xentop/Makefile |    2 +-
> > >  5 files changed, 53 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> > > index d67352e..aef9ed6 100644
> > > --- a/config/Tools.mk.in
> > > +++ b/config/Tools.mk.in
> > > @@ -77,5 +77,6 @@ CONFIG_LIBICONV     := @libiconv@
> > >  CONFIG_GCRYPT       := @libgcrypt@
> > >  EXTFS_LIBS          := @EXTFS_LIBS@
> > >  CURSES_LIBS         := @CURSES_LIBS@
> > > +TINFO_LIBS          := @TINFO_LIBS@
> > >
> > >  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
> > [...]
> > >
> > >
> > > diff --git a/tools/configure.ac b/tools/configure.ac
> > > index 9bf6450..1a06ddf 100644
> > > --- a/tools/configure.ac
> > > +++ b/tools/configure.ac
> > > @@ -318,6 +318,10 @@ i[[3456]]86|x86_64)
> > >  esac
> > >   AX_CHECK_UUID
> > >   AX_CHECK_CURSES
> > > +AS_IF([test "$ncurses" = "y"], [
> > > +AC_CHECK_LIB([tinfo], [define_key], [TINFO_LIBS=-ltinfo])
> >
> > "define_key"?
> 
> Why not? It is used by gtraceview. If you wish we could test for
> halfdelay() which is used by xentop.
> 

Oh, I misread, sorry. Testing for define_key is fine.

> > > +])
> > > +AC_SUBST(TINFO_LIBS)
> > >
> >
> > This doesn't look right. Tinfo is needed by libxenstat. It should not
> > depend on presence of curses library.
> 
> libtinfo is a part of ncurses.
> 

Well, not part of in the sense of packaging. Just that ncurses depends
on it. But I get your idea.

Wei.

> Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel