Re: [Xen-devel] [PATCH v1 COLO Pre 03/12] tools/libxc: export xc_bitops.h

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-06-04 at 09:01 +0800, Yang Hongyang wrote:
> 
> On 06/02/2015 06:11 PM, Andrew Cooper wrote:
> > On 02/06/15 10:26, Yang Hongyang wrote:
> >> When we are under COLO, we will send dirty page bitmap info from
> >> secondary to primary at every checkpoint. So we need to get/test
> >> the dirty page bitmap. We just expose xc_bitops.h for libxl use.
> >>
> >> NOTE:
> >>    Need to make clean and rerun configure to get it compiled.
> >>
> >> Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
> >
> > I like this change, but lets take the opportunity to fix some of the
> > issues in it.
> 
> Thanks, will fix in next version.

Please do fix and move in two separate patches, probably fix first
although I don't mind overall.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel