[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/sched_rt: Use the correct type for _cpumask_scratch



Hi Dario,

On 04/06/2015 09:57, Dario Faggioli wrote:
On Tue, 2015-06-02 at 16:07 +0100, Julien Grall wrote:
The commit 376bbbabbda607d2039b8f839f15ff02721597d2 "sched_rt: print useful
affinity info when dumping" breaks build on ARM64:

sched_rt.c: In function ârt_initâ:
sched_rt.c:442:26: error: assignment from incompatible pointer type [-Werror]
          _cpumask_scratch = xmalloc_array(cpumask_var_t, nr_cpu_ids);
                           ^
sched_rt.c: In function ârt_alloc_pdataâ:
sched_rt.c:489:29: error: passing argument 1 of âalloc_cpumask_varâ from 
incompatible pointer type [-Werror]
      if ( !alloc_cpumask_var(&_cpumask_scratch[cpu]) )

This is because cpumask_var_t is not a type alias to cpumask_t** when
the number of CPU > 2 * BITS_PER_LONG. The correct type for
_cpumask_scratch should be cpumask_var_t.

Oh, right.

Sorry for this, I didn't have an ARM build test sat up when working on
this patch and, although now I have it, I did not run it through it when
resending the patch (although, this is probably not only ARM related!).

It's only present on ARM64 build. ARM32 build perfectly fine.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.