Re: [Xen-devel] [PATCH 3/5] x86/link: Reduce the number of sections created

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.06.15 at 18:11, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 05/06/15 16:38, Jan Beulich wrote:
>>>>> On 05.06.15 at 15:31, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> There is no need for top level sections for each of these, so they are
>>> subsumed into more-generic sections.
>>>
>>>   .data.read_mostly and .lockprofile.data are moved to .data
>>>
>>>   .init.setup, .initcall.init, .xsm_initcall.init are moved to .init.data
>>>
>>> This will simplify the later adjustments to use superpages.
>> I'm curious, as I wouldn't expect the section count to matter there
>> at all. Generally, especially when having to disassemble a xen-syms
>> I find it quite useful if e.g. not all data is lumped together into one
>> big .data section.
> 
> With hindsight since writing, I think I can solve the conceptual problem
> I was having with extra commenting in the linker script.
> 
> Originally I attempting to coalesce all sections which would have
> identical superpage permissions, but this isn't exclusive with having
> these sections separately.

Good. I'll put this patch at the side then for the moment.

> Any thoughts about the .reloc section, at least moving it into it to
> between __init_begin and __init_end so it gets reclaimed on boot?

.reloc sits after _end (as it's of interest to only the EFI boot
loader code), and hence should already be getting reclaimed.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel