Re: [Xen-devel] [RFC 21/22] arm: Allow the user to specify the GIC version

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-06-05 at 17:00 +0100, Julien Grall wrote:
> >> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> >> index 648ca08..b033c0b 100644
> >> --- a/tools/libxl/xl_cmdimpl.c
> >> +++ b/tools/libxl/xl_cmdimpl.c
> >> @@ -1298,6 +1298,18 @@ static void parse_config_data(const char 
> >> *config_source,
> >>          !xlu_cfg_get_string (config, "cpus_soft", &buf, 0))
> >>          parse_vcpu_affinity(b_info, cpus, buf, num_cpus, false);
> >>  
> >> +    if (!xlu_cfg_get_string (config, "gic_version", &buf, 1)) {
> > 
> > Could we just make this an integer?
> 
> I choose the string solution over integer to not rule out the
> possibility to expose to the user a specific extension of the GICvn
> (such as V2M or ITS).

IMHO those should be separate booleans or options, but you are right
that I suppose we don't know that gicv5 won't be called the wombat
interrupt controller instead of v5.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel