Re: [Xen-devel] [PATCH v2 5/5] libxl: spawns two QEMUs for HVM guests

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 8 Jun 2015, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [PATCH v2 5/5] libxl: spawns two QEMUs for 
> HVM guests"):
> > Do you have any suggestions on how I could fix this function for the
> > purpose of this series? I would be quite happy to leave fixing
> > qdisk_spawn_outcome in libxl.c to you :-)
> 
> Sure.
> 
> > TBH as I wrote earlier, the failure of starting pv QEMU is not fatal
> > from the guest POV, so we could also leave it as is.
> 
> You need to collect the result anyway to avoid potentially leaking a
> pending callback and tearing down a still-active ao.
>
> I think the right answer is probably to start all the qemus in
> parallel, and count (or otherwise record) the spawn outcomes.

They are already started in parallel with this patch.
Where should libxl_create.c:qdisk_spawn_outcome store the outcome?
Somewhere in dcs->build_state? Who would check for that?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel