Re: [Xen-devel] [PATCH 3/4] EFI: support default attributes to map Runtime service areas with none given

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 09/06/15 16:26, Jan Beulich wrote:
>>>> On 09.06.15 at 16:08, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 09/06/15 14:53, Jan Beulich wrote:
>>> From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>>>
>>> For example on Dell machines we see:
>>>
>>> (XEN)  00000fed18000-00000fed19fff type=11 attr=8000000000000000
>>> (XEN) Unknown cachability for MFNs 0xfed18-0xfed19
>>>
>>> Let's allow them to be mapped as UC.
>>>
>>> We also alter the 'efi-rs' to be 'efi=rs' or 'efi=no-rs'.
>>>
>>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>
>>> --- a/docs/misc/xen-command-line.markdown
>>> +++ b/docs/misc/xen-command-line.markdown
>>> @@ -617,12 +617,24 @@ Either force retrieval of monitor EDID i
>>>  disable it (edid=no). This option should not normally be required
>>>  except for debugging purposes.
>>>  
>>> -### efi-rs
>>> -> `= <boolean>`
>>> +### efi
>>> +> `= List of [ rs | attr ]`
>>> +
>>> +All options are of boolean kind and can be prefixed with `no-` to
>>> +effect the inverse meaning.
>>> +
>>> +> `rs`
>>>  
>>>  > Default: `true`
>>>  
>>> -Force or disable use of EFI runtime services.
>>> +>> Force or disable use of EFI runtime services.
>>> +
>>> +> `attr=uc`
>>> +
>>> +> Default: `off`
>> `false` would be more consistent with the rest of the rest of the document.
> That's how Konrad had it originally, and I intentionally changed it,
> as consistency with the rest of the doc seemed less important to
> me than for this to make sense (and "off" to me makes more sense
> than "false" here).
>
>> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Please clarify whether this stands even without the above changed.

It stands.  I don't wish documentation quibbling to get in the way of
otherwise-good patches.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel