Re: [Xen-devel] [OSSTEST Nested PATCH v11 6/7] Compose the main recipe of nested test job

["Pang, LongtaoX" <longtaox.pang@xxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson [mailto:Ian.Jackson@xxxxxxxxxxxxx]
> Sent: Wednesday, June 10, 2015 11:42 PM
> To: Pang, LongtaoX
> Cc: xen-devel@xxxxxxxxxxxxx; Ian.Campbell@xxxxxxxxxx; wei.liu2@xxxxxxxxxx; Hu,
> Robert
> Subject: Re: [OSSTEST Nested PATCH v11 6/7] Compose the main recipe of nested
> test job
> 
> longtao.pang writes ("[OSSTEST Nested PATCH v11 6/7] Compose the main recipe
> of nested test job"):
> > The ident and guestname are same of 'nestedl1' for L1 guest VM.
> 
> This is going in the right direction.
> 
> I think arrangements need to be made to capture the logs for
> nestedl1.
> 
I am sorry, what logs do you mean? I noticed that there is one 
'logs/standalone' directory 
inside osstest repo. There are job logs that already have run.

> > +proc need-hosts/test-nested {} {return host}
> > +proc run-job/test-nested {} {
> > +    run-ts . = ts-debian-hvm-install + host + nestedl1
> > +    run-ts . = ts-nested-setup + host + nestedl1
> > +    run-ts . = ts-xen-install nestedl1
> > +    run-ts . = ts-host-reboot nestedl1
> > +    run-ts . = ts-debian-hvm-install nestedl1 nestedl2
> > +    run-ts . = ts-guest-stop nestedl1 nestedl2
> > +    run-ts . = ts-guest-destroy + host + nestedl1
> > +}
> 
> Very much a matter of taste, but can I suggest that `l1' and `l2'
> might be better idents/guest names names ?
> 
Yes, I will try it.

> I think some extra +s in the l2 install and start operations might be
> useful, because the testid probably doesn't need to mention nestedl1.
> 
I am sorry, do you mean that I should add '+' for l2 installation, 
such as ' ts-debian-hvm-install + nestedl1 + nestedl2' ? 

> I think you probably want to run leak-check on the L1.
> 
I have noticed the logs which printed on screen during job running, the 
leak-check will
be run on L1 at the end of testing.
Or, do you mean that I should run leak-check on L1 after the L1 HVM guest 
finishing installation?

> Do you not want to run the steps in test-guest ?  Perhaps it would be
> better to add a host ident argument to test-guest{,-migr,-nomigr} ?
> 
We do not plan to run the steps in test-guest currently.
> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel