Re: [Xen-devel] [OSSTEST Nested PATCH v11 2/7] Parsing grub which has 'submenu' primitive

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-06-11 at 11:17 +0800, Robert Hu wrote:

> > Unless I'm mistaken, the MenuEntryPath of a $submenu is never used ?
> > Not setting it would avoid (a) a need to rewrap and (b) me complaining
> > that you have open-coded the join twice.
> Actually this contribution from Ian Campbell.
> Hi Ian C., would you agree if I simply remove the 'MenuEntryPath' here? 

I left it as a debugging aid, since it shows up in Dumper($submenu)
which is convenient to sprinkle around while debuggiung. I don't mind if
it is removed or kept though.

Note that several patches from this series are already in osstest
production:

b77a6a2 Changes to support '/boot' leading paths of kernel, xen, in grub
997385f Parsing grub which has 'submenu' primitive
155bdb3 Move the code for setting memory size into prep()
2545fc6 Edit some APIs in TestSupport.pm for nested test
699c911 Refactor installation of overlays

So a incremental patch is what is needed here.

I fixed one or two issues as I committed, e.g. :
> > Missing spaces after if and inside `){'.
> OK, to refine these.

Worth double checking which I caught though.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel