Re: [Xen-devel] [PATCH v24 12/15] x86/VPMU: Handle PMU interrupts for PV(H) guests

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Thursday, June 11, 2015 5:33 PM
> 
> >>> On 11.06.15 at 10:38, <kevin.tian@xxxxxxxxx> wrote:
> >>  From: Boris Ostrovsky [mailto:boris.ostrovsky@xxxxxxxxxx]
> >> Sent: Wednesday, June 10, 2015 11:04 PM
> >>
> >> Add support for handling PMU interrupts for PV(H) guests.
> >>
> >> VPMU for the interrupted VCPU is unloaded until the guest issues
> > XENPMU_flush
> >> hypercall. This allows the guest to access PMU MSR values that are stored 
> >> in
> >> VPMU context which is shared between hypervisor and domain, thus avoiding
> >> traps to hypervisor.
> >>
> >> Since the interrupt handler may now force VPMU context save (i.e. set
> >> VPMU_CONTEXT_SAVE flag) we need to make changes to amd_vpmu_save() which
> >> until now expected this flag to be set only when the counters were stopped.
> >>
> >> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> >> Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> >
> > I may need more time to understand the whole interrupt stuff for PV(H)
> > guest. But regarding to VMX specific changes I think they are clear:
> >
> > Signed-off-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> 
> I don't think you really meant S-o-b here?
> 

My bad when doing batch reviews.

Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>

Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel