Re: [Xen-devel] [PATCH v3 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi,

On 11/06/2015 04:31, Wei Wang wrote:
> -    list_for_each(pos, &cpufreq_governor_list)
> +    if (policy->policy)
What if another cpufreq decides to use policy->policy?

> +        gov_num = INTEL_PSTATE_INTERNAL_GOV_NUM;
Why not using cpufreq_governor_list?

> +    else
> +    {
> +        list_for_each(pos, &cpufreq_governor_list)
>           gov_num++;
The indentation looks wrong to me.

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel