Re: [Xen-devel] [v3][PATCH 00/16] Fix RMRR

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.06.15 at 04:10, <tiejun.chen@xxxxxxxxx> wrote:
> On 2015/6/11 20:52, Tim Deegan wrote:
>> which would be better handeld explicitly:
>>
>>         if ( p2mt == p2m_invalid || p2mt == p2m_mmio_dm )
>>             ...
>>
> 
> So if I'm correct, we should do this check explicitly,
> 
>         if ( p2mt == p2m_invalid ||
>              (p2mt == p2m_mmio_dm && !mfn_valid(mfn) )
> 
> Note this is equivalent to Jan's comment.

I think the !mfn_valid() part is really redundant - p2m_mmio_dm
should never be put on a page translating to a valid MFN.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel