Re: [Xen-devel] [PATCH 1/4] hvmloader: Fixup pci_write* macros

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 06/15/15 10:19, Andrew Cooper wrote:
> On 15/06/15 15:15, Don Slutz wrote:
>> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>
>> CC: Don Slutz <dslutz@xxxxxxxxxxx>
> 
> Fix how?  It looks like you are bracketing val.
> 

If val is an expression, the macro most likely does the wrong thing.

For example:

pci_writeb(devfn, PCI_IO_BASE, addr >> PCI_IO_SHIFT);


is pci_write(devfn, reg, 1, (uint8_t)addr >> PCI_IO_SHIFT); which is not
correct.  I would expect:

pci_write(devfn, reg, 1, (uint8_t)(addr >> PCI_IO_SHIFT));

> This is an improvement, but please always be specific as to what is
> being fixed.
> 

Does:

Improve pci_write* macros to act like a function does.

scan better?

> Furthermore, what about devfn or reg?
> 

devfn and reg do not need the bracketing since they are just passed,
but I have no issue with adding the extra brackets.

   -Don Slutz

> ~Andrew
> 
>> ---
>>  tools/firmware/hvmloader/util.h | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/firmware/hvmloader/util.h 
>> b/tools/firmware/hvmloader/util.h
>> index a70e4aa..8431f2d 100644
>> --- a/tools/firmware/hvmloader/util.h
>> +++ b/tools/firmware/hvmloader/util.h
>> @@ -82,9 +82,9 @@ uint32_t pci_read(uint32_t devfn, uint32_t reg, uint32_t 
>> len);
>>  #define pci_readw(devfn, reg) ((uint16_t)pci_read(devfn, reg, 2))
>>  #define pci_readl(devfn, reg) ((uint32_t)pci_read(devfn, reg, 4))
>>  void pci_write(uint32_t devfn, uint32_t reg, uint32_t len, uint32_t val);
>> -#define pci_writeb(devfn, reg, val) (pci_write(devfn, reg, 1, (uint8_t) 
>> val))
>> -#define pci_writew(devfn, reg, val) (pci_write(devfn, reg, 2, 
>> (uint16_t)val))
>> -#define pci_writel(devfn, reg, val) (pci_write(devfn, reg, 4, 
>> (uint32_t)val))
>> +#define pci_writeb(devfn, reg, val) (pci_write(devfn, reg, 1, (uint8_t) 
>> (val)))
>> +#define pci_writew(devfn, reg, val) (pci_write(devfn, reg, 2, 
>> (uint16_t)(val)))
>> +#define pci_writel(devfn, reg, val) (pci_write(devfn, reg, 4, 
>> (uint32_t)(val)))
>>  
>>  /* Get a pointer to the shared-info page */
>>  struct shared_info *get_shared_info(void) __attribute__ ((const));
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel