Re: [Xen-devel] [PATCH OSSTEST v2 09/11] ts-xen-build-prep: install libc6-dev-i386 for jessie

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jun 15, 2015 at 05:21:12PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH OSSTEST v2 09/11] ts-xen-build-prep: install 
> libc6-dev-i386 for jessie"):
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ...
> > diff --git a/ts-xen-build-prep b/ts-xen-build-prep
> > index 4fdc37e..c348dad 100755
> > --- a/ts-xen-build-prep
> > +++ b/ts-xen-build-prep
> > @@ -232,7 +232,7 @@ END
> >      if ($ho->{Suite} !~ m/lenny|squeeze/) {
> >          target_install_packages($ho, 'libfdt-dev');
> >      }
> > -    if ($r{arch} eq 'amd64' && $ho->{Suite} =~ m/wheezy/) {
> > +    if ($r{arch} eq 'amd64' && $ho->{Suite} =~ m/wheezy|jessie/) {
> >          target_install_packages($ho, 'libc6-dev-i386');
> 
> If we are expecting this to be permanent, rather than it being a bug
> in wheezy, I think the sense of the test here is wrong, and we should
> be listing the older suites which don't need it.
> 

Yes, this is going to be permanent. The root cause is wheezy onwards
introduces multi-arch that separates amd64 and i386.

I will reverse logic: add that package in the initial set and remove it
for older suites.

Wei.

> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel