[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCHv2 3/5] evtchn: use a per-event channel lock for sending events



On 16/06/15 16:19, David Vrabel wrote:
>>> @@ -1221,6 +1277,8 @@ void notify_via_xen_event_channel(struct domain *ld, 
>>> int lport)
>>>          evtchn_port_set_pending(rd, rchn->notify_vcpu_id, rchn);
>>>      }
>>>  
>>> +    spin_unlock(&lchn->lock);
>>> +
>>>      spin_unlock(&ld->event_lock);
>>>  }
>>
>> Again I think the event lock can be dropped earlier now.
> 
> Ditto.

Uh, no. This is notify.  I've kept the locking like this because of the
ld->is_dying check.  I think we need the ld->event_lock in case
d->is_dying is set and evtchn_destroy(ld) is called.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.