Re: [Xen-devel] [PATCH 23/27] tools/libxl: [RFC] Write checkpoint records into the stream

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 18/06/15 04:13, Wen Congyang wrote:
>> @@ -139,6 +169,15 @@ static void stream_failed(libxl__egc *egc,
>> >      assert(rc);
>> >      stream->rc = rc;
>> >  
>> > +    /*
>> > +     *If we are in a checkpoint, pass the failure to libxc, which will 
>> > come
>> > +     * back around to us via libxl__xc_domain_save_done().
>> > +     */
>> > +    if (stream->in_checkpoint) {
> I think we should set running to false here too.
>
> Thanks
> Wen Congyang
>

"running" encapsulates that a stream is being written, which includes
time when libxc is writing into the fd below us.

In particular, setting running to false here will prevent the stream
from being correctly torn down if the libxl-save-helper process
encounters an error.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel