Re: [Xen-devel] [PATCH] x86/HVM: EOI handling function adjustments

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 18/06/15 13:51, Jan Beulich wrote:
> --- a/xen/arch/x86/hvm/vlapic.c
> +++ b/xen/arch/x86/hvm/vlapic.c
> @@ -421,18 +421,17 @@ void vlapic_EOI_set(struct vlapic *vlapi
>      if ( hvm_funcs.handle_eoi )
>          hvm_funcs.handle_eoi(vector);
>  
> -    if ( vlapic_test_and_clear_vector(vector, &vlapic->regs->data[APIC_TMR]) 
> )
> -        vioapic_update_EOI(vlapic_domain(vlapic), vector);
> -
> -    hvm_dpci_msi_eoi(current->domain, vector);
> +    vlapic_handle_EOI(vlapic, vector);
>  }
>  
> -void vlapic_handle_EOI_induced_exit(struct vlapic *vlapic, int vector)
> +void vlapic_handle_EOI(struct vlapic *vlapic, u8 vector)
>  {
> +    struct domain *d = vlapic_domain(vlapic);
> +
>      if ( vlapic_test_and_clear_vector(vector, &vlapic->regs->data[APIC_TMR]) 
> )
> -        vioapic_update_EOI(vlapic_domain(vlapic), vector);
> +        vioapic_update_EOI(d, vector);
>  
> -    hvm_dpci_msi_eoi(current->domain, vector);
> +    hvm_dpci_msi_eoi(d, vector);

It might be worth retaining an ASSERT(current->domain == d) at this point.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel