Re: [Xen-devel] [PATCH] drivers: xen-blkfront: only talk_to_blkback() when in XenbusStateInitialising

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.06.15 at 15:56, <konrad.wilk@xxxxxxxxxx> wrote:
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -1951,6 +1951,8 @@ static void blkback_changed(struct xenbus_device *dev,
>  
>       switch (backend_state) {
>       case XenbusStateInitWait:
> +             if (dev->state != XenbusStateInitialising)
> +                     break;

If, as you say in a subsequent reply, all other drivers already have
such a check, wouldn't it make more sense to put this into xenbus'
backend_changed() or even xenbus_otherend_changed()?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel