Re: [Xen-devel] [v4][PATCH 03/19] xen/vtd: create RMRR mapping

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.06.15 at 11:57, <tiejun.chen@xxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -1839,7 +1839,7 @@ static int rmrr_identity_mapping(struct domain *d, 
> bool_t map,
>  
>              while ( base_pfn < end_pfn )
>              {
> -                if ( intel_iommu_unmap_page(d, base_pfn) )
> +                if ( guest_physmap_remove_page(d, base_pfn, base_pfn, 0) )
>                      ret = -ENXIO;
>                  base_pfn++;
>              }
> @@ -1855,8 +1855,7 @@ static int rmrr_identity_mapping(struct domain *d, 
> bool_t map,
>  
>      while ( base_pfn < end_pfn )
>      {
> -        int err = intel_iommu_map_page(d, base_pfn, base_pfn,
> -                                       IOMMUF_readable|IOMMUF_writable);
> +        int err = set_identity_p2m_entry(d, base_pfn, p2m_access_rw);

Shouldn't the two continue to be the inverse of one another?
Maybe guest_physmap_remove_page() does what you want,
but it looks like at least an abuse.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel