Re: [Xen-devel] [PATCH 1/2] Revert "libxl: fix "xl mem-set" regression from 0c029c4da2"

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jun 23, 2015 at 03:45:14PM +0100, Jan Beulich wrote:
> >>> On 23.06.15 at 16:16, <wei.liu2@xxxxxxxxxx> wrote:
> > This reverts commit f5b43e95facdc17f925cb56a8963cd4531074034.
> 
> Even if the patch having introduced the regression this fixed is
> being reverted, it's not clear to me why this change needs to be
> reverted too - it seems correct to me to use 64-bit types for the
> calculations. Or are you planning to do a more comprehensive
> adjustments to all of the types later on?
> 

I was thinking more about giving Ian (who is looking at making things
consistent) a clean state to start with. He may end up touching those
types.

This patch itself looks correct to me.

Ian, I think I will send a patch to revert the only offending commit and
fix up conflicts. Are you OK with that.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel