Re: [Xen-devel] [PATCH v2 04/12] x86/altp2m: basic data structures and support routines.

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/06/15 11:29, Andrew Cooper wrote:
> On 22/06/15 19:56, Ed White wrote:
>> diff --git a/xen/include/asm-x86/hvm/vcpu.h b/xen/include/asm-x86/hvm/vcpu.h
>> index 3d8f4dc..a1529c0 100644
>> --- a/xen/include/asm-x86/hvm/vcpu.h
>> +++ b/xen/include/asm-x86/hvm/vcpu.h
>> @@ -118,6 +118,13 @@ struct nestedvcpu {
>>  
>>  #define vcpu_nestedhvm(v) ((v)->arch.hvm_vcpu.nvcpu)
>>  
>> +struct altp2mvcpu {
>> +    uint16_t    p2midx;         /* alternate p2m index */
>> +    uint64_t    veinfo_gfn;     /* #VE information page guest pfn */
> Please use the recently-introduced pfn_t here.  pfn is a more
> appropriate term than gfn in this case.

And of course, I meant to say that gfn should be the term to use, since
this is a guest physical address, from its point of view.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel