[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 5/9] x86/pvh: Set PVH guest's mode in XEN_DOMCTL_set_address_size
- To: Jan Beulich <JBeulich@xxxxxxxx>
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Wed, 24 Jun 2015 07:42:10 -0400
- Cc: elena.ufimtseva@xxxxxxxxxx, tim@xxxxxxx, Kevin Tian <kevin.tian@xxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Eddie Dong <eddie.dong@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxx, Jun Nakajima <jun.nakajima@xxxxxxxxx>, roger.pau@xxxxxxxxxx
- Delivery-date: Wed, 24 Jun 2015 11:42:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 06/24/2015 03:57 AM, Jan Beulich wrote:
On 24.06.15 at 04:53, <boris.ostrovsky@xxxxxxxxxx> wrote:
On 06/23/2015 09:22 AM, Jan Beulich wrote:
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -2320,12 +2320,7 @@ int hvm_vcpu_initialise(struct vcpu *v)
v->arch.hvm_vcpu.inject_trap.vector = -1;
if ( is_pvh_domain(d) )
- {
- v->arch.hvm_vcpu.hcall_64bit = 1; /* PVH 32bitfixme. */
- /* This is for hvm_long_mode_enabled(v). */
- v->arch.hvm_vcpu.guest_efer = EFER_LMA | EFER_LME;
return 0;
- }
With this removed, is there any guarantee that hvm_set_mode()
will be called for each vCPU?
IIUIC, toolstack is required to call XEN_DOMCTL_set_address_size which
results in a call to switch_compat/native(), which loop over all VCPUs,
calling set_mode.
I don't recall this being a strict requirement. I think a PV 64-bit
guest would start fine without.
We do call it via libxl__build_pv() -> xc_dom_boot_mem_init() ->
arch_setup_mem_init() -> x86_compat().
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
