Re: [Xen-devel] [PATCH v4 09/17] x86/hvm: unify stdvga mmio intercept with standard mmio intercept

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.06.15 at 16:12, <Paul.Durrant@xxxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: 24 June 2015 14:59
>> >>> On 24.06.15 at 13:24, <paul.durrant@xxxxxxxxxx> wrote:
>> > -    if ( s->stdvga && s->cache )
>> > -    {
>> > -        switch ( p->type )
>> > -        {
>> > -        case IOREQ_TYPE_COPY:
>> > -            buf = mmio_move(s, p);
>> > -            if ( !buf )
>> > -                s->cache = 0;
>> > -            break;
>> > -        default:
>> > -            gdprintk(XENLOG_WARNING, "unsupported mmio request type:%d
>> "
>> > -                     "addr:0x%04x data:0x%04x size:%d count:%d state:%d "
>> > -                     "isptr:%d dir:%d df:%d\n",
>> > -                     p->type, (int)p->addr, (int)p->data, (int)p->size,
>> > -                     (int)p->count, p->state,
>> > -                     p->data_is_ptr, p->dir, p->df);
>> > -            s->cache = 0;
>> > -        }
>> 
>> I can't see where these cases of clearing s->cache move to.
>> 
> 
> There's only one case AFAICT, which is if the domain goes through a 
> save/restore then s->cache is cleared.

There are two cases visible in the context above, which afaict
have nothing to do with save/restore.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel