Re: [Xen-devel] [PATCH OSSTEST v3 14/22] Debian: Do not add Debian to UEFI boot order on install

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v3 14/22] Debian: Do not add Debian to 
UEFI boot order on install"):
> By default Debian inserts itself before any existing entries,
> including the PXE one, meaning we otherwise cannot remotely regroove
> the box.

Right.

> +    if (get_host_property($ho, "firmware") eq "uefi" &&
> +     $ho->{Suite} =~ m/jessie/) {

I think you mean

  +    if (get_host_property($ho, "firmware") eq "uefi")
  +     die unless $ho->{Suite} =~ m/jessie/;

or this will expose us to broken boxes beyond jessie.


The rest looks plausible (although a bit unpleasant).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel