[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v7 5/9] PCI: Add pci_iomap_wc() variants
- To: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Toshi Kani <toshi.kani@xxxxxx>, Andy Lutomirski <luto@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Tomi Valkeinen <tomi.valkeinen@xxxxxx>
- From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
- Date: Wed, 24 Jun 2015 18:38:22 +0200
- Cc: linux-fbdev@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, Ville Syrjälä <syrjala@xxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, jbeulich@xxxxxxxx, ville.syrjala@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, arnd@xxxxxxxx, Davidlohr Bueso <dbueso@xxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, Daniel Vetter <daniel.vetter@xxxxxxxx>, Dave Airlie <airlied@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Borislav Petkov <bp@xxxxxxx>, Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>, Antonino Daplas <adaplas@xxxxxxxxx>, Suresh Siddha <sbsiddha@xxxxxxxxx>, Stefan Bader <stefan.bader@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, david.vrabel@xxxxxxxxxx, venkatesh.pallipadi@xxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 24 Jun 2015 16:38:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Wed, Jun 24, 2015 at 08:42:23AM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2015-06-19 at 15:08 -0700, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> >
> > PCI BARs tell us whether prefetching is safe, but they don't say anything
> > about write combining (WC). WC changes ordering rules and allows writes to
> > be collapsed, so it's not safe in general to use it on a prefetchable
> > region.
>
> Well, the PCIe spec at least specifies that a prefetchable BAR also
> tolerates write merging...
How can that be determined and can that be used as a full bullet proof hint
to enable wc ? And are you sure? :) Reason all this was stated was to be
apologetic over why we can't automate this behind the scenes. Otherwise
we could amend what you stated into the commit log to elaborate on our
technical apology. Let me know!
Luis
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
