Re: [Xen-devel] [PATCH 1/6] pvh: domu construct vmcb 64 bit mode start

[Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>]

On Tue, Jun 23, 2015 at 01:02:49PM +0100, Jan Beulich wrote:
> >>> On 22.06.15 at 18:37, <elena.ufimtseva@xxxxxxxxxx> wrote:
> > From: Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>
> > 
> > Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> 
> As long as this patch originally cam from Mukesh, From: should
> reflect that imo. Once you made changes, you S-o-b would be
> required alongside his.
> 
> > --- a/xen/arch/x86/hvm/svm/vmcb.c
> > +++ b/xen/arch/x86/hvm/svm/vmcb.c
> > @@ -162,7 +162,12 @@ static int construct_vmcb(struct vcpu *v)
> >      vmcb->ds.attr.bytes = 0xc93;
> >      vmcb->fs.attr.bytes = 0xc93;
> >      vmcb->gs.attr.bytes = 0xc93;
> > -    vmcb->cs.attr.bytes = 0xc9b; /* exec/read, accessed */
> > +
> > +    if ( is_pvh_vcpu(v) )
> > +        /* CS.L == 1, exec, read/write, accessed. PVH 32bitfixme. */
> > +        vmcb->cs.attr.bytes = 0xa9b;
> > +    else
> > +        vmcb->cs.attr.bytes = 0xc9b; /* exec/read, accessed */
> 
> With 32-bit support now actively being worked on, I don't think
> we want to see any new 32bitfixme-s proposed to go in. Plus it
> needs settling on whether the boot mode is to change for PVH.

Yep, I will work on this with Boris patches in mind.

> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel