Re: [Xen-devel] [PATCH v4 14/17] x86/hvm: remove hvm_io_state enumeration

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 25 June 2015 10:44
> To: Paul Durrant
> Cc: Andrew Cooper; xen-devel; Keir (Xen.org)
> Subject: Re: [PATCH v4 14/17] x86/hvm: remove hvm_io_state enumeration
> 
> >>> On 24.06.15 at 13:24, <paul.durrant@xxxxxxxxxx> wrote:
> > Emulation request status is already covered by STATE_IOREQ_XXX values
> so
> > just use those. The mapping is:
> >
> > HVMIO_none                -> STATE_IOREQ_NONE
> > HVMIO_awaiting_completion -> STATE_IOREQ_READY
> > HVMIO_completed           -> STATE_IORESP_READY
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks.

> subject to possibly ...
> 
> > @@ -50,7 +44,7 @@ struct hvm_vcpu_asid {
> >
> >  struct hvm_vcpu_io {
> >      /* I/O request in flight to device model. */
> > -    enum hvm_io_state      io_state;
> > +    uint8_t                io_state;
> >      unsigned long          io_data;
> >      int                    io_size;
> >      enum hvm_io_completion io_completion;
> 
> ... finding a better slot for this single byte (not sure what the
> structure looks like at this point of the series).

Probably not worth it. The state gets pulled into an ioreq_t (along with 
io_data and io_size) in a later patch.

  Paul

> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel