Re: [Xen-devel] [RFC PATCH v3 03/18] xen: console: Add ratelimit support for error message

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Mon, Jun 22, 2015 at 6:51 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 22.06.15 at 14:01, <vijay.kilari@xxxxxxxxx> wrote:
>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>>
>> XENLOG_ERR_RATE_LIMIT and XENLOG_G_ERR_RATE_LIMIT
>> log levels are added to support rate limit for error messages
>
> If you mean to say that rate limiting currently doesn't work for
> XENLOG_ERR messages, then that's a problem to be fixed by
> adjusting existing code, not by adding yet another log level.

For GUEST messages  ERR and WARN are rate limited by
setting lower threshold to 0 and upper threshold to 2 as below

#define XENLOG_GUEST_UPPER_THRESHOLD 2 /* Do not print INFO and DEBUG  */
#define XENLOG_GUEST_LOWER_THRESHOLD 0 /* Rate-limit ERR and WARNING   */

So do you recommend to set same threshold levels to Xen messages
there by ERR & WARN are rate limited?

Regards
Vijay

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel