Re: [Xen-devel] [PATCH] libxl: locally attach disks with hotplug scripts for bootloader execution

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 06/25/2015 03:17 PM, Roger Pau Monne wrote:
> Or else bootloader execution fails. Tested using an iSCSI disk.
>
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Reported-by: Hildebrand, Nils <Nils.Hildebrand@xxxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> ---
>  tools/libxl/libxl.c | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 9117b01..6430836 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -3063,9 +3063,16 @@ void 
> libxl__device_disk_local_initiate_attach(libxl__egc *egc,
>
>      switch (disk->backend) {
>          case LIBXL_DISK_BACKEND_PHY:
> -            LIBXL__LOG(ctx, LIBXL__LOG_DEBUG, "locally attaching PHY disk 
> %s",
> -                       disk->pdev_path);
> -            dev = disk->pdev_path;
> +            if (disk->script == NULL && disk->backend_domname == NULL) {
> +                LOG(DEBUG, "locally attaching PHY disk %s", disk->pdev_path);
> +                dev = disk->pdev_path;
> +            } else {
> +                libxl__prepare_ao_device(ao, &dls->aodev);
> +                dls->aodev.callback = local_device_attach_cb;
> +                device_disk_add(egc, LIBXL_TOOLSTACK_DOMID, disk, 
> &dls->aodev,
> +                                libxl__alloc_vdev, (void *) blkdev_start);
> +                return;
> +            }

Although having said that -- isn't there also a bug here wrt qdisk
backends in a driver domain not being attached?

Could we do something like the attached patch?

This will do a local attach for blktap as well, which isn't strictly
necessary, but should work pretty much the same as for the block
scripts.  (And anyway I'm about to replace the blktap stuff with block
scripts anyway.)

 -George

Attachment: 0001-libxl-Make-local_initiate_attach-more-rational.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel