[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH v2 08/15] xen/arm: gic-{v2, hip04}: Remove redundant check in {gicv2, hip04gic}_init
There is a global check for page alignment later within the same function. Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx> Cc: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> --- Changes in v2: - Add Ian's ack - Merge "gic-v2: Remove redundant check in gicv2_init" and "gic-hip04: Remove redundant check in hip04gic_init" --- xen/arch/arm/gic-hip04.c | 8 ++++---- xen/arch/arm/gic-v2.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/gic-hip04.c b/xen/arch/arm/gic-hip04.c index 669d043..71cdba0 100644 --- a/xen/arch/arm/gic-hip04.c +++ b/xen/arch/arm/gic-hip04.c @@ -679,19 +679,19 @@ static int __init hip04gic_init(void) const struct dt_device_node *node = gicv2_info.node; res = dt_device_get_address(node, 0, &gicv2.dbase, NULL); - if ( res || !gicv2.dbase || (gicv2.dbase & ~PAGE_MASK) ) + if ( res || !gicv2.dbase ) panic("GIC-HIP04: Cannot find a valid address for the distributor"); res = dt_device_get_address(node, 1, &gicv2.cbase, NULL); - if ( res || !gicv2.cbase || (gicv2.cbase & ~PAGE_MASK) ) + if ( res || !gicv2.cbase ) panic("GIC-HIP04: Cannot find a valid address for the CPU"); res = dt_device_get_address(node, 2, &gicv2.hbase, NULL); - if ( res || !gicv2.hbase || (gicv2.hbase & ~PAGE_MASK) ) + if ( res || !gicv2.hbase ) panic("GIC-HIP04: Cannot find a valid address for the hypervisor"); res = dt_device_get_address(node, 3, &gicv2.vbase, NULL); - if ( res || !gicv2.vbase || (gicv2.vbase & ~PAGE_MASK) ) + if ( res || !gicv2.vbase ) panic("GIC-HIP04: Cannot find a valid address for the virtual CPU"); res = platform_get_irq(node, 0); diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index 9e55b21..cecb092 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -665,19 +665,19 @@ static int __init gicv2_init(void) const struct dt_device_node *node = gicv2_info.node; res = dt_device_get_address(node, 0, &gicv2.dbase, NULL); - if ( res || !gicv2.dbase || (gicv2.dbase & ~PAGE_MASK) ) + if ( res || !gicv2.dbase ) panic("GICv2: Cannot find a valid address for the distributor"); res = dt_device_get_address(node, 1, &gicv2.cbase, NULL); - if ( res || !gicv2.cbase || (gicv2.cbase & ~PAGE_MASK) ) + if ( res || !gicv2.cbase ) panic("GICv2: Cannot find a valid address for the CPU"); res = dt_device_get_address(node, 2, &gicv2.hbase, NULL); - if ( res || !gicv2.hbase || (gicv2.hbase & ~PAGE_MASK) ) + if ( res || !gicv2.hbase ) panic("GICv2: Cannot find a valid address for the hypervisor"); res = dt_device_get_address(node, 3, &gicv2.vbase, NULL); - if ( res || !gicv2.vbase || (gicv2.vbase & ~PAGE_MASK) ) + if ( res || !gicv2.vbase ) panic("GICv2: Cannot find a valid address for the virtual CPU"); res = platform_get_irq(node, 0); -- 2.4.3 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |