Re: [Xen-devel] [v2] nested EPT: fix the handling of nested EPT

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.06.15 at 23:57, <liang.z.li@xxxxxxxxx> wrote:
> If the host EPT entry is changed, the nested EPT should be updated.
> the current code does not do this, and it's wrong.
> I have tested this patch, the L2 guest can boot and run as normal.
> 
> Signed-off-by: Liang Li <liang.z.li@xxxxxxxxx>
> Signed-off-by: Yang Zhang <yang.z.li@xxxxxxxxx>
> Reported-by: Tim Deegan <tim@xxxxxxx>

Please don't forget to Cc the maintainer (recently changed, now
added).

> @@ -1076,6 +1077,9 @@ void ept_sync_domain(struct p2m_domain *p2m)
>  
>      ASSERT(local_irq_is_enabled());
>  
> +    if ( nestedhvm_enabled(d) && !p2m_is_nestedp2m(p2m) ) {
> +        p2m_flush_nestedp2m(d);
> +    }
>      /*

Coding style: Braces aren't really needed here, but you should leave
a blank line between your addition and the following comment.

> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -1742,6 +1742,10 @@ p2m_flush_table(struct p2m_domain *p2m)
>      ASSERT(page_list_empty(&p2m->pod.super));
>      ASSERT(page_list_empty(&p2m->pod.single));
>  
> +    if ( p2m->np2m_base == P2M_BASE_EADDR ) {
> +        p2m_unlock(p2m);
> +        return;
> +    }
>      /* This is no longer a valid nested p2m for any address space */

Since braces are needed here, they should be placed properly.
Same comment as above regarding the missing blank line.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel