Re: [Xen-devel] [PATCH v2] OSSTest: stop testing SEDF, start testing RTDS

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-06-26 at 12:58 +0200, Dario Faggioli wrote:
> the SEDF scheduler is about to be deprecated and go
> away (see [1]). OTOH, the RTDS scheduler is here to
> stay.
> 
> It therefore makes sense to stop smoke testing the
> former in favour of the latter. Note that the
> -sedf-pin jobs where only added in order to try to
> debug a long standing issue with SEDF; it is not
> necessary to have anything like that for RTDS.
> 
> For now, as RTDS is still marked as experimental,
> test failures are allowed, as it is for SEDF.
> 
> Also, RTDS was introduced in Xen 4.5, so add the
> test only for the relevant brnaches. Similarly,
> SEDF is removed in Xen 4.6, so keep testing it in
> older branches.
> 
> [1] http://lists.xen.org/archives/html/xen-devel/2015-05/msg02874.html

osstest needs an S-o-b too I'm afraid.

Otherwise LGTM, Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
> Attached, a diff (between before and after applying
> the patch) of the output of:
> ./standalone-generate-dump-flight-runvars xen-unstable xen-4.5-testing 
> xen-4.4-testing xen-4.3-testing
> 
> v1 was here:
> http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg03050.html
> 
> Changes from v1:
>  * gate the new test (and the disabling of the
>    old one) on the actual Xen version
> 
> diff --git a/allow.all b/allow.all
> index f0bbdd3..88a3038 100644
> --- a/allow.all
> +++ b/allow.all
> @@ -1,4 +1,5 @@
>  test-@@-sedf@@
> +test-@@-rtds@@
>  build-@@                        logs-capture@@
>  test-@@-pcipt@@
>  test-@@-qemuu-@@             guest-localmigrate
> diff --git a/make-flight b/make-flight
> index 78ace52..31cb942 100755
> --- a/make-flight
> +++ b/make-flight
> @@ -275,7 +275,7 @@ do_hvm_rhel6_tests () {
>  }
>  
>  do_sedf_tests () {
> -  if [ $xenarch != $dom0arch ]; then
> +  if [ $xenarch != $dom0arch -o x$test_sedf != xy ]; then
>      return
>    fi
>  
> @@ -300,6 +300,17 @@ do_credit2_tests () {
>              $debian_runvars all_hostflags=$most_hostflags
>  }
>  
> +do_rtds_tests () {
> +  if [ $xenarch != $dom0arch -o x$test_rtds != xy ]; then
> +    return
> +  fi
> +
> +  job_create_test test-$xenarch$kern-$dom0arch-xl-rtds                \
> +       test-debian xl $xenarch $dom0arch                              \
> +            guests_vcpus=4 xen_boot_append='sched=rtds'               \
> +            $debian_runvars all_hostflags=$most_hostflags
> +}
> +
>  do_multivcpu_tests () {
>    if [ $xenarch != $dom0arch ]; then
>      return
> @@ -362,7 +373,21 @@ test_matrix_do_one () {
>    do_pv_debian_tests
>  
>    do_multivcpu_tests
> +
> +  # RTDS came in 4.4, while SEDF is going away in 4.6
> +  case "$xenbranch" in
> +  xen-3.*-testing) test_sedf=y; test_rtds=n ;;
> +  xen-4.0-testing) test_sedf=y; test_rtds=n ;;
> +  xen-4.1-testing) test_sedf=y; test_rtds=n ;;
> +  xen-4.2-testing) test_sedf=y; test_rtds=n ;;
> +  xen-4.3-testing) test_sedf=y; test_rtds=n ;;
> +  xen-4.4-testing) test_sedf=y; test_rtds=n ;;
> +  xen-4.5-testing) test_sedf=y; test_rtds=y ;;
> +  *)               test_sedf=n; test_rtds=y ;;
> +  esac
> +
>    do_sedf_tests
> +  do_rtds_tests
>    do_credit2_tests
>  
>    # No further arm tests at the moment
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel