Re: [Xen-devel] [v4][PATCH 16/19] tools/libxl: extend XENMEM_set_memory_map

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jun 26, 2015 at 03:13:17PM +0800, Chen, Tiejun wrote:
> On 2015/6/25 19:33, Wei Liu wrote:
> >The subject line should be changed. You're not extending that hypercall.
> >
> >libxl: construct e820 map with RDM information for HVM guest
> >
> 
> Agreed.
> 
> >On Tue, Jun 23, 2015 at 05:57:27PM +0800, Tiejun Chen wrote:
> >>Here we'll construct a basic guest e820 table via
> >>XENMEM_set_memory_map. This table includes lowmem, highmem
> >>and RDMs if they exist. And hvmloader would need this info
> >>later.
> >>
> >
> >I have one question. When RDM is disabled, the generated e820 map should
> >look exactly the same as before (i.e. without this patch), right?
> 
> Yes.
> 
> >
> >Whatever the answer is, please say that in your commit log.
> 
> What about this sentence?
> 
> Note this guest e820 table would be same as before if the
> platform has no any RDMs or we disable RDM (by default).
> 

Yes this looks good.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel