Re: [Xen-devel] [RFC PATCH v3 00/18] Add ITS support

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-06-22 at 17:31 +0530, vijay.kilari@xxxxxxxxx wrote:
> Vijaya Kumar K (18):
>   xen/arm: Add bitmap_find_next_zero_area helper function
>   xen: Add log2 functionality
>   xen: console: Add ratelimit support for error message
>   xen/arm: gicv3: Refactor redistributor information
>   xen/arm: ITS: Port ITS driver to xen
>   xen/arm: ITS: Add helper functions to manage its_devices
>   xen/arm: ITS: implement hw_irq_controller for LPIs
>   xen/arm: vITS: Add virtual ITS driver
>   xen/arm: ITS: Add virtual ITS commands support
>   xen/arm: ITS: Add APIs to add and assign device
>   xen/arm: ITS: Add GITS registers emulation
>   xen/arm: ITS: Add GICR register emulation
>   xen/arm: ITS: Add irq descriptors for LPIs
>   xen/arm: ITS: Initialize physical ITS
>   xen/arm: ITS: Add domain specific ITS initialization
>   xen/arm: ITS: Handle LPI interrupts
>   xen/arm: ITS: Generate ITS node for Dom0
>   xen/arm: ITS: Map ITS translation space

FWIW I think it would be more logical to order this as:
      * Preparation, precursor cleanups etc
      * PITS support
      * VITS support, which uses pits stuff
      * Domain vits init, including map the ITS translation page, which
        uses vits stuff
      * Device Tree mangling which finally exposes the result to the
        guest.

But I think far more critical would be to make function which whould
eventually be static be so when it is introduced (not later) and to
include prototypes of functions in the patch which adds the function.
Also lots more const correctness would be good.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel