[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [OSSTEST PATCH 03/13] Reporting: sg-report-flight: Fix undefined value in $worstrow[]



The fallback entry in the worstrow search, used when a job has not
been run at all, was wrong.  Also, fix the doc comment which induced
the mistake.

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
 sg-report-flight |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sg-report-flight b/sg-report-flight
index 6481521..117b609 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -965,7 +965,7 @@ END
 
     my $cell_html = sub {
        my ($ei, $core_only) = @_;
-       # => ($h, $priority);
+       # => ($h, $priority, $ch);
        my $s= $ei->{Step};
        my $sum_core= $ei->{SummaryCore};
        $sum_core= $ei->{Summary} if !defined $sum_core;
@@ -998,7 +998,7 @@ END
     my @worstrow1;
     my @worstrow2;
     foreach my $col (@cols) {
-       my @worst=(' bgcolor="#444444">',0);
+       my @worst=('',0,'bgcolor="#444444"','');
        foreach my $rowix (0..$#{ $fi->{GridRows} }) {
             my $ei= $fi->{GridGrid}{$col}[$rowix];
            next unless $ei;
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.