Re: [Xen-devel] [OSSTEST PATCH 05/13] Reporting: report_run_getinfo produces ColourAttr

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-06-29 at 18:14 +0100, Ian Jackson wrote:
> This includes the bgcolour attribute name and the quotes.  This will
> make it possible for this function to sometimes not set a background
> for the whole table cell in the future (which will be part of putting
> multiple step results in each cell).
> 
> No functional change.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
>  Osstest/Executive.pm   |    5 ++++-
>  sg-report-host-history |    2 +-
>  sg-report-job-history  |    3 +--
>  3 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
> index 2389eb2..f53d271 100644
> --- a/Osstest/Executive.pm
> +++ b/Osstest/Executive.pm
> @@ -205,7 +205,10 @@ sub report_run_getinfo ($) {
>  
>      my $single = sub {
>       my ($summary, $colour) = @_;
> -     return { Summary => $summary, Colour => $colour };
> +     return {
> +         Summary => $summary,
> +         ColourAttr => " bgcolor=\"$colour\"",

FWIW all the uses have a space before there $ri->{ColourAttr}, so
strictly you don't need it here, I think.

Nonetheless:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel