Re: [Xen-devel] [OSSTEST PATCH 08/13] Reporting: Break out report_blessingscond

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [OSSTEST PATCH 08/13] Reporting: Break out 
report_blessingscond"):
> On Tue, 2015-06-30 at 10:31 +0100, Ian Jackson wrote:
> > IMO `-' is valid in blessings.  Consider `commission-oseleta'.
> 
> I'm being very confused -- I was thinking of flight names, not blessing
> names.

Ah.  Yes, I think `-' isn't legal in flight names.  Even that letters
are permitted is a concession :-).

> I've just done "./standalone -f xen-unstable xen-unstable" and it seems
> to have worked but:
> 
> $ ./mg-show-flight-runvars xen-unstable
> Died at ./mg-show-flight-runvars line 42.
> 
> Which is from:
>         die unless @ARGV==1 && $ARGV[0] =~ m/^\w+$/;
> 
> I also notice that standalone-generate-flight-runvars is laundering out
> the - too.

Perhaps having a central regexp for flight names would be a good
thing, yes, but I don't think it's relevant for this patch.  I suggest
we cross that bridge next time we have to introduce another ad-hoc
check for a flight name.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel