Re: [Xen-devel] [PATCH v2 03/15] xen/arm: vGIC: Export vgic_vN ops rather than add an indirection

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-06-26 at 10:34 +0100, Julien Grall wrote:
> The function vgic_vN_init only calls register_vgic_ops. As it will never
> contain anything else, domain initialization code should be in the
> callback domain_init, remove them and directly use the VGIC ops in the
> commmon vGIC code.

Too many m's in common.

> +#define DEFINE_VGIC_OPS(version)                        \
> +    extern const struct vgic_ops vgic_v##version##_ops;
> +DEFINE_VGIC_OPS(2)
> +#ifdef HAS_GICV3
> +DEFINE_VGIC_OPS(3)
> +#endif
> +#undef DEFINE_VGIC_OPS

I think the macro is a bit unnecessary, to externs would have been just
fine.

Either way:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel