Re: [Xen-devel] [PATCH] docs: Fix docs output after commit 6592bf6

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Andrew,

On 30/06/15 13:35, Andrew Cooper wrote:
> On 30/06/15 13:22, Julien Grall wrote:
>> A find option was forgotten in commit 
>> 6592bf60beaf1fa0b4fd36fb73800eb001c739af
>> "docs: Look for documentation in sub-directories" resulting to get some
>> docs duplicated and other missing.
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> ---
>>  docs/Makefile | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/docs/Makefile b/docs/Makefile
>> index 0ee6808..272292c 100644
>> --- a/docs/Makefile
>> +++ b/docs/Makefile
>> @@ -10,9 +10,9 @@ DOC_ARCHES      := arm x86_32 x86_64
>>  MAN1SRC-y += $(sort $(shell find man -name 'xl*.pod.1' -print))
>>  MAN1SRC-y += $(sort $(shell find man -name 'xenstore*.pod.1' -print))
>>  
>> -MAN5SRC-y := $(sort $(shell find man 'xl*.pod.5' -print))
>> +MAN5SRC-y := $(sort $(shell find man -name 'xl*.pod.5' -print))
> 
> All of the sources should look for *.pod.1 and *.pod.5, without being
> more specific about an xl or a xenstore prefix.
> 
> They were only like that because of limitations with the older
> $(wildcard ...) invocation.

What kind of limitations? Similar pattern were used to match markdown
and txt.

In anycase, the patch which replaced wildcard by find retains the same
behavior. Changing the pattern is not a bug and should be part of a
separate patch.

Feel free to send a follow-up.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel