Re: [Xen-devel] [PATCH 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 01/07/15 14:41, Ben Catterall wrote:
> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> The sh_map/unmap wrappers can be dropped, and take the opportunity to turn
> some #define's into static inlines, for added type saftey.
>
> As part of adding the type safety, GCC highlights an problematic include cycle
> with arm/mm.h including domain_page.h which includes xen/mm.h and falls over
> __page_to_mfn being used before being declared.  Simply dropping the inclusion
> of domain_page.h fixes the compilation issue.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Tim Deegan <tim@xxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>

One thing to note is that the mm maintainer has changed since I wrote
this patch.  CC'ing George with his new hat on.  (The same applies to
all patches in this series)

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel