[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH 0/2] libxl: fix NUMA placement preventing domain config to be re-used


This series fixes the issue reported here by Ian, about NUMA placement related
domain config fields preventing the config to be reused:

The way it does it is by setting the b_info->numa_placement config switch to
false, after NUMA placement has actually happened. This way, the next time we
re-use the config, we won't run the placement again, we just will use the
result obtained from the original execution of it. This is, both IMO and for
Ian Jackson (as per an IRC conversation we had yesterday), the best behaviour,
as it yields consistent results across config re-uses.

BTW, with patch 2 applied, I've been able to run the test in here, and it
worked for me:

While I was there, though, I took the chance to put patch 1 together as well.
What it does it turning a couple of error conditions (still related to the NUMA
placement domain config switch) into warnings, as error was too much. This has
been discussed a while back, and I distinctly remember it mentioned in a
conversation on xen-devel, but I can't find it now. In any case, I think it's
the right thing to do.

Dario Faggioli (2):
      libxl: turn NUMA placement misconfigs into warnings
      libxl: unset info->numa_placement upon successful placement

 tools/libxl/libxl_dom.c |   85 +++++++++++++++++++++++++----------------------
 1 file changed, 46 insertions(+), 39 deletions(-)
<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.