Re: [Xen-devel] [PATCH 2/3] xen/domain_page: Convert copy/clear_domain_page() to using mfn_t

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 01/07/15 17:07, David Vrabel wrote:
> On 01/07/15 14:57, Andrew Cooper wrote:
>> On 01/07/15 14:41, Ben Catterall wrote:
>>> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>> [Convert grant_table.c to pass mfn_t types and fix ARM compiling]
>>>
>>> Signed-off-by: Ben Catterall <Ben.Catterall@xxxxxxxxxx>
>> Reviwed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> for the additions
>> beyond my half of the patch.
>>
>> Also CC'ing George and David as maintainers of areas touched.
> For this sort of tree-wide mechanical change I wouldn't generally
> expected to need acks/reviews from specific subsystem maintainers.

Fair enough.

>>> --- a/xen/common/kimage.c
>>> +++ b/xen/common/kimage.c
>>> @@ -77,7 +77,7 @@ static struct page_info 
>>> *kimage_alloc_zeroed_page(unsigned memflags)
>>>      if ( !page )
>>>          return NULL;
>>>  
>>> -    clear_domain_page(page_to_mfn(page));
>>> +    clear_domain_page(_mfn(page_to_mfn(page)));
> Seems odd that page_to_mfn() doesn't return the correct type and needs
> the "cast".

page_to_mfn() and all the other similar helpers are also on the list of
stuff needing cleaning up.  The intermediate _mfn() call will eventually
disappear, but updating everything together is massive task.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel